From 647395dd6a9152ddb9d298daff21c6a3ada6d80b Mon Sep 17 00:00:00 2001 From: "David T. Sadler" Date: Mon, 1 Nov 2021 21:01:11 +0000 Subject: Return false if saving fails --- src/DTS/BookmarkRepository.php | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/DTS/BookmarkRepository.php b/src/DTS/BookmarkRepository.php index 675cb8b..a2d80cd 100644 --- a/src/DTS/BookmarkRepository.php +++ b/src/DTS/BookmarkRepository.php @@ -148,18 +148,20 @@ class BookmarkRepository implements \Iterator throw new \Exception("Unable to open repository {$this->pathToRepository}"); } + $success = true; + foreach ($this->repository as $bookmark) { - fputcsv($fp, [ + $success = $success && fputcsv($fp, [ $bookmark->id, $bookmark->url, $bookmark->title, $bookmark->tag, $bookmark->addedAt, - ]); + ]) !== false; } fclose($fp); - return true; + return $success; } } -- cgit v1.2.3-13-gbd6f